Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amina/cfd 4813 diel #17474

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Amina/cfd 4813 diel #17474

wants to merge 4 commits into from
+268 −51

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 15, 2024 11:22am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17474](https://github.com/deriv-com/deriv-app/pull/17474)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-cfd4813diel.binary.sx?qa_server=red.derivws.com&app_id=30371
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-cfd4813diel.binary.sx
- **App ID**: `30371`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-cfd4813diel.binary.sx/

@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11855036151

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 8 of 28 (28.57%) changed or added relevant lines in 4 files are covered.
  • 998 unchanged lines in 114 files lost coverage.
  • Overall coverage increased (+5.7%) to 53.219%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/core/src/Stores/traders-hub-store.js 0 20 0.0%
Files with Coverage Reduction New Missed Lines %
packages/account/src/Configs/get-mt5-status-badge-config.tsx 1 0.0%
packages/account/src/index.tsx 1 0.0%
packages/account/src/Sections/Profile/PersonalDetails/verify-button.tsx 1 95.38%
packages/appstore/src/constants/wallet-migration-video-translations.ts 1 71.43%
packages/appstore/src/modules/traders-hub/index.tsx 1 88.51%
packages/appstore/src/stores/index.ts 1 0.0%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/inputs/qs-input-label.tsx 1 71.43%
packages/bot-web-ui/src/pages/bot-builder/quick-strategy/selects/symbol.tsx 1 97.22%
packages/indicators/src/indicators/relative-strength-index.js 1 97.44%
packages/p2p/src/components/modal-manager/modals/share-my-ads-modal/share-my-ads-modal.tsx 1 85.45%
Totals Coverage Status
Change from base Build 11776475915: 5.7%
Covered Lines: 32755
Relevant Lines: 57455
💛 - Coveralls

likhith-deriv
likhith-deriv previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amina-deriv @coveralls @likhith-deriv @suisin-deriv